Comboboxのガイドラインを追加 #1152
Merged
Comboboxのガイドラインを追加 #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for smarthr-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
「SingleComboboxとMultiComboboxのPropsが長大で見辛い」とのことですが、わけたページに中身がなく、Propsだけのページになってしまっているので、これなら長大になっててもまとまってて（ページ分割しなくて）もよいなと思った派です。 |
versionfive
reviewed
May 13, 2024
|
ページ分ける場合、最後のSingleComboBoxとMultiComboBoxへのリンクがタイトルにあることに気づきづらかったです。
|
ayumizu
previously requested changes
May 13, 2024
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Co-authored-by: ayumizu <99632029+ayumizu@users.noreply.github.com>
tosiiu
reviewed
May 13, 2024
Co-authored-by: Ura Toshihiro <48958782+tosiiu@users.noreply.github.com>
Co-authored-by: Ura Toshihiro <48958782+tosiiu@users.noreply.github.com>
Co-authored-by: Ura Toshihiro <48958782+tosiiu@users.noreply.github.com>
versionfive
previously approved these changes
May 15, 2024
content/articles/products/components/combo-box/multi-combo-box.mdx
Outdated
Show resolved
Hide resolved
content/articles/products/components/combo-box/single-combo-box.mdx
Outdated
Show resolved
Hide resolved
content/articles/products/components/combo-box/multi-combo-box.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
…x.mdx Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
….mdx Co-authored-by: versionfive <64398878+versionfive@users.noreply.github.com>
Qs-F
reviewed
May 17, 2024
content/articles/products/components/combo-box/multi-combo-box.mdx
Outdated
Show resolved
Hide resolved
Qs-F
reviewed
May 17, 2024
content/articles/products/components/combo-box/single-combo-box.mdx
Outdated
Show resolved
Hide resolved
Qs-F
previously approved these changes
May 17, 2024
tosiiu
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題・背景
やったこと
やらなかったこと
動作確認